aminghadersohi commented on PR #40346: URL: https://github.com/apache/superset/pull/40346#issuecomment-4522453958
Thanks for the thorough review! Addressed in ecec0a0864: **#1 — Addressed:** Dropped `sql` from `DEFAULT_QUERY_COLUMNS`. A bare `list_queries()` no longer returns full SQL bodies by default; callers use `select_columns` or `get_query_info`. **#2 — Addressed:** Removed both `QueryError.create()` and `SavedQueryError.create()` dead classmethods. **#3 — Addressed:** Added `changed_on` to `SORTABLE_QUERY_COLUMNS` for queries. The column is indexed (`ti_user_id_changed_on`) and the DAO supports it, same treatment as saved queries. **#4 — Addressed (partially):** Added a `select_columns` projection test and an invalid `order_column` rejection test. Skipped the `InternalError` path since the list tools re-raise and that path is already covered by the middleware tests. **#5 — Addressed:** Fixed the `list_queries` entry in `app.py` to say "(1-based pagination)" consistent with all other list tools. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
