Copilot commented on code in PR #39980:
URL: https://github.com/apache/superset/pull/39980#discussion_r3291302883
##########
superset-frontend/playwright/tests/dashboard/dashboard-list.spec.ts:
##########
@@ -293,12 +318,12 @@ test.describe('import dashboard', () => {
label: `Dashboard ${dashboardId}`,
});
- // Refresh to confirm dashboard is no longer in the list
+ // Refresh to confirm dashboard is no longer in the list (deleted rows are
removed from the DOM, so assert count rather than visibility)
await dashboardListPage.goto();
await dashboardListPage.waitForTableLoad();
- await expect(
- dashboardListPage.getDashboardRow(dashboardName),
- ).not.toBeVisible();
+ await expect(dashboardListPage.getDashboardRow(dashboardName)).toHaveCount(
+ 0,
Review Comment:
In the import-dashboard test, the post-delete assertion uses
`toHaveCount(0)` with the default expect timeout. Elsewhere in this file
similar post-delete list-view assertions use `timeout: TIMEOUT.API_RESPONSE` to
accommodate slow CI propagation; this one can still flake if the re-fetch is
delayed. Consider adding the same extended timeout here for consistency and
reliability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
