hainenber commented on code in PR #40281:
URL: https://github.com/apache/superset/pull/40281#discussion_r3292118096
##########
superset-frontend/src/pages/UsersList/index.tsx:
##########
@@ -287,14 +303,14 @@ function UsersList({ user }: UsersListProps) {
id: 'login_count',
Header: t('Login count'),
hidden: true,
- Cell: ({ row: { original } }: any) => original.login_count,
+ Cell: renderLoginCountCell,
Review Comment:
```suggestion
Cell: ({ row: { original } }: any) => original.login_count ?? 0,
```
##########
superset-frontend/src/pages/UsersList/index.tsx:
##########
@@ -287,14 +303,14 @@ function UsersList({ user }: UsersListProps) {
id: 'login_count',
Header: t('Login count'),
hidden: true,
- Cell: ({ row: { original } }: any) => original.login_count,
+ Cell: renderLoginCountCell,
},
{
accessor: 'fail_login_count',
id: 'fail_login_count',
Header: t('Fail login count'),
hidden: true,
- Cell: ({ row: { original } }: any) => original.fail_login_count,
+ Cell: renderFailLoginCountCell,
Review Comment:
```suggestion
Cell: ({ row: { original } }: any) => original.fail_login_count ?? 0,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
