sha174n commented on code in PR #39302:
URL: https://github.com/apache/superset/pull/39302#discussion_r3293221765
##########
superset/security/api.py:
##########
@@ -83,6 +83,17 @@ class GuestTokenCreateSchema(PermissiveSchema):
user = fields.Nested(UserSchema)
resources = fields.List(fields.Nested(ResourceSchema), required=True)
rls = fields.List(fields.Nested(RlsRuleSchema), required=True)
+ datasets = fields.List(
+ fields.Integer(),
+ load_default=None,
+ metadata={
+ "description": (
+ "Optional allowlist of dataset IDs the guest may access. "
+ "When omitted all datasets linked to the embedded dashboard "
+ "are accessible, preserving the default behaviour."
+ )
+ },
+ )
Review Comment:
Already addressed — schema includes both `load_default=None` and
`allow_none=True`, so explicit `null` payloads deserialize successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
