bito-code-review[bot] commented on code in PR #40000:
URL: https://github.com/apache/superset/pull/40000#discussion_r3293321892
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx:
##########
@@ -143,9 +114,6 @@ const FilterValue: FC<FilterValueProps> = ({
}) => {
const { id, targets, filterType } = filter;
const isCustomization = isChartCustomization(filter);
- const allowedTimeGrains = isCustomization
- ? undefined
- : (filter as TimeGrainFilterConfig).time_grains;
const adhocFilters = isCustomization ? undefined : filter.adhoc_filters;
const timeRange = isCustomization ? undefined : filter.time_range;
const granularitySqla = isCustomization ? undefined :
filter.granularity_sqla;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Orphaned config with no consumer</b></div>
<div id="fix">
Removed `applyTimeGrainAllowlist` and `TimeGrainFilterConfig` type, but
`filterTransformer.ts` still persists `time_grains` from native filter configs
into `Filter.time_grains`. This orphaned configuration has no consumer—users
will set `time_grains` expecting filtered options but see all time grains
instead. Either remove the configuration serialization or restore the filtering
logic.
</div>
</div>
<small><i>Code Review Run #995125</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
