bito-code-review[bot] commented on code in PR #40378: URL: https://github.com/apache/superset/pull/40378#discussion_r3290458779
########## pyproject.toml: ########## @@ -154,7 +154,7 @@ fastmcp = [ ] firebird = ["sqlalchemy-firebird>=0.7.0, <2.2"] firebolt = ["firebolt-sqlalchemy>=1.0.0, <2"] -gevent = ["gevent>=23.9.1"] +gevent = ["gevent>=26.4.0"] Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Lock file out of sync</b></div> <div id="fix"> The requirements/development.txt pins gevent==24.2.1 while pyproject.toml now specifies gevent>=26.4.0. Per BITO.md rule 10438, lock files should not be manually edited. Regenerate development.txt via pip-compile to restore consistency and avoid developers hitting version mismatches during local setup. </div> </div> <small><i>Code Review Run #bc947a</i></small> </div><div> <div id="suggestion"> <div id="issue"><b>Lock file version inconsistency</b></div> <div id="fix"> The lock file pins gevent==24.2.1, which falls below the new minimum constraint of >=26.4.0. While the constraint itself is satisfied (24.2.1 <= 26.4.0 is false), this inconsistency may cause confusion during lock file regeneration or deployment. Consider updating the pinned version to match the new minimum. </div> </div> <small><i>Code Review Run #a90a64</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
