kasiazjc opened a new pull request, #40422: URL: https://github.com/apache/superset/pull/40422
### TL;DR The column select popover in Explore has a tab labeled **"Saved"** that shows calculated columns defined on the dataset. The Dataset Editor calls that same concept **"Calculated columns"**. This renames the Explore tab to **"Calculated"** (fits the tab width) and updates the inner form label/empty-state text to match. ### What changed - `ColumnSelectPopover.tsx`: tab label `Saved` → `Calculated`, form label `Saved expressions` → `Calculated columns`, empty state title `No saved expressions found` → `No calculated columns found` - `ColumnSelectPopover.test.tsx`: updated test assertions and description to match new labels ### What was NOT changed - Internal tab key (`'saved'`) — no runtime behavior change, just the visible label - Default tab selection logic — still opens on the tab that matches what's currently selected (Calculated if a calculated column is active, Simple otherwise) - The word "Virtual" in the Dataset Editor — that refers to datasource *type* (Virtual SQL vs physical table), which is a separate, correct concept ### Context Tracked in sc-46962. The original report also mentioned "Virtual" vs "Saved" — the "Virtual" side was already resolved (dataset editor now says "Calculated columns", not "Virtual"). This PR closes the remaining terminology gap on the Explore side. ### Testing Existing unit tests updated and passing. Manually verify by opening the column select popover in Explore on a dataset with calculated columns — the tab should now read "Calculated" instead of "Saved". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
