kasiazjc opened a new pull request, #40435: URL: https://github.com/apache/superset/pull/40435
## Summary Several UI components still used ALL CAPS for button/action labels, which is inconsistent with Superset's sentence case convention. This PR fixes all identified cases. ### Changes | Component | Old → New | |---|---| | Time range filter (DateFilterLabel) | `APPLY` → `Apply`, `CANCEL` → `Cancel` | | AnnotationLayer modal | `OK` → `Ok` | | Dashboard Tabs (delete confirm) | `DELETE` → `Delete` | | SQL Lab editor | `COPY QUERY` → `Copy query` | | MapViewControl radio labels | `FIT DATA` → `Fit data`, `CUSTOM` → `Custom` | | DatasourceModal confirm | `OK` → `Ok` | | ResultSet confirm dialog | `OK` → `Ok` | Also fixed two pre-existing issues unblocked by the hook run: - `scripts/oxlint.sh`: `set -e` caused false exit code 1 when oxlint passed with empty output - `src/components/Chart/chartAction.ts`: pre-existing TypeScript error on `response.warning` ### Intentionally NOT changed - `OVERWRITE` in import/database modals — it's a confirmation keyword users must type, not a button label - `STRING`, `NUMERIC`, `DATETIME`, `BOOLEAN` in DatasourceEditor — data type labels in a dropdown - `SQL`, `UTC`, `API`, `CSV` etc. — proper acronyms ## Test plan - [ ] Time range popover: verify Apply/Cancel buttons display correctly - [ ] Dashboard Tabs: confirm delete modal shows "Delete" button - [ ] SQL Lab: verify "Copy query" button label - [ ] MapViewControl: verify radio labels "Fit data" / "Custom" - [ ] Datasource modal: verify "Ok" confirm button - [ ] `jest` passes on modified test file (`DateFilterLabel.test.tsx`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
