codeant-ai-for-open-source[bot] commented on code in PR #40443: URL: https://github.com/apache/superset/pull/40443#discussion_r3304463380
########## superset/extensions/settings.py: ########## @@ -0,0 +1,108 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""Admin settings persistence for extensions (active chatbot, enable/disable).""" + +from typing import Any + +from sqlalchemy.dialects.postgresql import insert as pg_insert +from sqlalchemy.dialects.sqlite import insert as sqlite_insert + +from superset import db +from superset.models.core import ExtensionEnabled, ExtensionSettings +from superset.utils.decorators import transaction + +_SETTINGS_ROW_ID = 1 + + +def get_extension_settings() -> dict[str, Any]: + row = db.session.get(ExtensionSettings, _SETTINGS_ROW_ID) + enabled_rows = db.session.query(ExtensionEnabled).all() + return { + "active_chatbot_id": row.active_chatbot_id if row else None, + "enabled": {r.extension_id: r.enabled for r in enabled_rows}, + } + + +def _upsert_settings_row( + active_chatbot_id: str | None, +) -> None: + """Upsert the singleton settings row without a read-then-insert race.""" + bind = db.session.get_bind() + dialect = bind.dialect.name + if dialect == "postgresql": + stmt = ( + pg_insert(ExtensionSettings) + .values(id=_SETTINGS_ROW_ID, active_chatbot_id=active_chatbot_id) + .on_conflict_do_update( + index_elements=["id"], + set_={"active_chatbot_id": active_chatbot_id}, + ) + ) + db.session.execute(stmt) + else: + stmt = ( + sqlite_insert(ExtensionSettings) + .values(id=_SETTINGS_ROW_ID, active_chatbot_id=active_chatbot_id) + .on_conflict_do_update( + index_elements=["id"], + set_={"active_chatbot_id": active_chatbot_id}, + ) + ) + db.session.execute(stmt) Review Comment: **🟠Architect Review — HIGH** The extension settings upsert helpers treat every non-PostgreSQL dialect as SQLite and build sqlite_insert(...).on_conflict_do_update statements, so on MySQL/MariaDB metadata databases PUT /api/v1/extensions/settings will run a SQLite-specific ON CONFLICT statement against a MySQL engine and fail. **Suggestion:** Branch explicitly on the actual dialect (e.g. handle "postgresql" and "sqlite" separately and fall back to a dialect-agnostic insert+update sequence for others) so both _upsert_settings_row and _upsert_enabled_flag work on MySQL/MariaDB as well as PostgreSQL and SQLite. [Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=56023dc5ccad46e0b37d14e6a91611c3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=56023dc5ccad46e0b37d14e6a91611c3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is an **Architect / Logical Review** comment left during a code review. These reviews are first-class, important findings — not optional suggestions. Do NOT dismiss this as a 'big architectural change' just because the title says architect review; most of these can be resolved with a small, localized fix once the intent is understood. **Path:** superset/extensions/settings.py **Line:** 47:66 **Comment:** *HIGH: The extension settings upsert helpers treat every non-PostgreSQL dialect as SQLite and build sqlite_insert(...).on_conflict_do_update statements, so on MySQL/MariaDB metadata databases PUT /api/v1/extensions/settings will run a SQLite-specific ON CONFLICT statement against a MySQL engine and fail. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. If a suggested approach is provided above, use it as the authoritative instruction. If no explicit code suggestion is given, you MUST still draft and apply your own minimal, localized fix — do not punt back with 'no suggestion provided, review manually'. Keep the change as small as possible: add a guard clause, gate on a loading state, reorder an await, wrap in a conditional, etc. Do not refactor surrounding code or expand scope beyond the finding. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
