serenajiang opened a new pull request #8224: [wip][sqllab] create query slightly earlier URL: https://github.com/apache/incubator-superset/pull/8224 ### CATEGORY Choose one - [X] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Part of the ongoing saga of trying to fix `stop_query` issues. Flips the order of the rejected tables check and query creation so that queries are created slightly earlier. This might prevent errors like `No row was found for one()` if a user stops the query before it is actually created. This also means that if a user doesn't have access to the tables in the query, the query will still be recorded in the queries table with the status `QueryStatus.FAILED`. Previously, these queries were not recorded. ### TEST PLAN ### REVIEWERS
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
