RaghunandanKumar commented on code in PR #40386:
URL: https://github.com/apache/superset/pull/40386#discussion_r3307507055
##########
superset-frontend/plugins/plugin-chart-pivot-table/test/react-pivottable/tableRenders.test.tsx:
##########
@@ -159,6 +159,26 @@ test('TableRenderer renders grand total when both totals
are enabled', () => {
expect(grandTotalCells[0]).toHaveTextContent('4');
});
+test('TableRenderer renders subvalue labels for row and column subtotals', ()
=> {
+ const props = buildDefaultProps({
+ tableRenderer: 'Table With Subtotal',
+ tableOptions: {
+ rowSubtotalPosition: true,
+ colSubtotalPosition: true,
+ },
+ });
+ renderWithTheme(<TableRenderer {...props} />);
+
+ const subtotalLabels = Array.from(
+ document.querySelectorAll('.pvtSubtotalLabel'),
+ )
+ .map(cell => cell.textContent?.trim())
+ .filter(Boolean);
+
+ expect(subtotalLabels).toContain('Subvalue');
+ expect(subtotalLabels).not.toContain('Subtotal');
Review Comment:
Thanks. I addressed the valid part of this review: the test now uses
`rowSubTotals` / `colSubTotals`. One correction: `tableRenderer` is not what
makes subtotal labels appear here. For `TableRenderer`, subtotal labels render
only when subtotal flags are enabled and the test data produces partial
row/column keys, so the follow-up test also uses multi-level dimensions to
exercise a real subtotal case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
