aminghadersohi commented on PR #39922: URL: https://github.com/apache/superset/pull/39922#issuecomment-4553045373
Rebased onto current master (incorporated `09a94fa26b` and `7e088792b9`). CI was green on the previous HEAD and the rebase was conflict-free. Tagging for community review: @mistercrunch @villebro @michael-s-molina — this PR introduces a `ChartTypePlugin` registry that consolidates all chart-type-specific dispatch into a single plugin per type. Before this change, adding a new `generate_chart`-supported type required coordinated edits to four separate locations (`schema_validator.py`, `dataset_validator.py`, `chart_utils.py`, `runtime/__init__.py`). After this change it requires one new file in `superset/mcp_service/chart/plugins/`. The PR also fixes a latent bug where 5 of 7 chart types silently skipped column validation before this refactor. CI is fully green. Happy to address any feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
