dhaksdhakshin opened a new pull request, #40488:
URL: https://github.com/apache/superset/pull/40488
### SUMMARY
The `DEFAULT_CHART_ERROR` constant in `ChartErrorMessage.tsx` was a plain
string (`'Data error'`), so it was never extracted by `pybabel` and never
translated. Users in non-English locales saw the English title regardless of
their language setting.
This wraps the constant with `t()` from `@apache-superset/core/translation`,
matching the sibling `ErrorMessageWithStackTrace`'s `DEFAULT_TITLE =
t('Unexpected error')` pattern.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — no visual change in the default English locale. Behavior change is
only that the string becomes extractable and translatable.
### TESTING INSTRUCTIONS
1. Run the existing unit test:
It still passes — `t()` returns the source string when no translation is
loaded, so `screen.getByText('Data error')` continues to resolve.
2. After running `pybabel extract` the new `msgid "Data error"` will appear
in `superset/translations/messages.pot`, ready for translators.
### ADDITIONAL INFORMATION
- [x] Has associated issue: Fixes #40406
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
