sha174n commented on code in PR #40329:
URL: https://github.com/apache/superset/pull/40329#discussion_r3319528032
##########
superset/commands/tag/create.py:
##########
@@ -60,9 +60,35 @@ def validate(self) -> None:
exceptions.append(
TagCreateFailedError(f"invalid object type
{self._object_type}")
)
+
+ # Validate user has access to the target object
+ if object_type:
+ self._validate_object_access(object_type, self._object_id,
exceptions)
Review Comment:
Intentional difference: the bulk path uses `raise_for_ownership` (stricter,
edit-level) with soft-skip semantics for partial bulk success; the
single-object path now dispatches per object type via `raise_for_object_access`
in ee49b2f5d3, which fixes a related bypass where `hasattr(target,
raise_for_access)` was silently False for charts and saved queries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
