sha174n commented on code in PR #40499:
URL: https://github.com/apache/superset/pull/40499#discussion_r3321394182
##########
superset/sql/parse.py:
##########
@@ -1667,6 +1709,7 @@ def transpile_to_dialect(
# Get source dialect (default to generic if not specified)
source_dialect = SQLGLOT_DIALECTS.get(source_engine) if source_engine else
Dialect
+ _check_script_length(sql, source_engine)
Review Comment:
Moved the length gate inside the try block so SupersetParseError is wrapped
into QueryClauseValidationException, preserving the error contract for
transpile_virtual_dataset_sql and other callers. Applied the same fix to
extract_tables_from_statement (which had the same pattern, swallowing parse
errors with return set()). cad8d0b76a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
