sha174n opened a new pull request, #40524:
URL: https://github.com/apache/superset/pull/40524
### SUMMARY
Removes the `workflow_run` trigger and the two `if`-gated artifact-download
branches that depended on it. The remaining `push` (`docs/**` and `README.md`
on `master`) and `workflow_dispatch` triggers both resolve `github.sha` against
the default branch's HEAD, so the deploy job and its repository-local action
always execute from a trusted tree.
### Changes
- `on:` block: drop `workflow_run` (deploy after `Python-Integration`
completes). `push` (docs/** and README on master) and `workflow_dispatch` are
retained.
- Diagnostics-artifact download: collapse the two `if`-gated branches into a
single step that always uses the `branch: master, search_artifacts: true,
if_no_artifact_found: warn` fallback. The previous `workflow_run`-only branch
read the same artifact via `run_id: ${{ github.event.workflow_run.id }}`, which
is no longer reachable.
- Checkout `ref:` simplified from `${{ github.event.workflow_run.head_sha ||
github.sha }}` to plain `${{ github.sha }}` since `workflow_run.head_sha` is no
longer reachable.
- `commit-message` template fallback changes from `triggered by integration
tests` to `manual dispatch` to match the remaining trigger set.
### Behaviour after this change
| Trigger | Before | After |
|---|---|---|
| Push to `docs/**` or `README.md` on master | Deploy | Deploy (unchanged) |
| `workflow_dispatch` | Deploy | Deploy (unchanged) |
| Python-Integration completes on master | Deploy | No deploy |
| Push to non-docs file on master | No deploy | No deploy (unchanged) |
Every docs change merged to master goes through one of the two retained
triggers, so the published docs site continues to update on every merge that
touches `docs/**` or `README.md`. The `workflow_run` path was redundant: it
re-ran the same build after the Python-Integration job finished, but the same
content had already been built and deployed by the `push` trigger.
### Testing instructions
- Trigger a deploy via the Actions UI ("Run workflow" on
`superset-docs-deploy.yml`); confirm the workflow runs and deploys the docs
site as before.
- Push a no-op change to `docs/README.md` on a branch, merge to master;
confirm the `push` trigger fires and deploys.
- Inspect a recent run's "Try to download latest diagnostics" step; confirm
it still finds the latest `database-diagnostics` artifact on master via the
existing fallback.
### Additional information
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
- [x] Includes CI/workflow changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
