kristw commented on a change in pull request #8229: [POC] add echarts scatter
URL:
https://github.com/apache/incubator-superset/pull/8229#discussion_r324821011
##########
File path: superset/viz.py
##########
@@ -2765,6 +2765,15 @@ def get_data(self, df):
return self.nest_values(levels)
+class EchartsScatter(BubbleViz):
Review comment:
We had light discussions about listing `postprocessing` operations as a new
field in the `api/v1/query` parameters to call those pandas functionality in
addition to the simple table query that it already support, but none had the
cycle to draft the API spec nor work on it yet. If you would like to step in,
that could be helpful.
I was thinking something along the line of
```js
const queryFormData = {
group_by,
adhoc_filters,
...etc.
// Add a new field that takes an array of post-processing operations
// which we could enforce the schema in typescript
// then you need to modify /api/v1/query in python to handle it.
postProcessing = [ { operation: '', options: {...} } ];
}
```
See
[superset-ui/query](https://github.com/apache-superset/superset-ui/blob/master/packages/superset-ui-query/src/types/QueryFormData.ts)
for current `QueryFormData` schema.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
