aminghadersohi commented on code in PR #40356: URL: https://github.com/apache/superset/pull/40356#discussion_r3326698300
########## superset/mcp_service/rls/schemas.py: ########## @@ -0,0 +1,138 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +""" +Pydantic schemas for RLS (row-level security) MCP tools. +""" + +from __future__ import annotations + +from typing import Literal + +from pydantic import BaseModel, ConfigDict, Field + + +class CreateRLSFilterRequest(BaseModel): + model_config = ConfigDict(populate_by_name=True) + + name: str = Field(..., min_length=1, description="Name for the RLS filter rule.") + filter_type: Literal["Regular", "Base"] = Field( + ..., + description=( + 'Type of filter. "Regular" hides rows from the specified roles ' + 'unless the clause matches. "Base" shows only rows where the ' + "clause matches to the specified roles." + ), Review Comment: Fixed in the latest commit. The `filter_type` field now correctly documents both semantics: Regular applies the clause only to users with the specified roles; Base applies the clause to ALL users EXCEPT users with the specified roles (those roles bypass the filter and see all rows). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
