codeant-ai-for-open-source[bot] commented on code in PR #40355: URL: https://github.com/apache/superset/pull/40355#discussion_r3326703818
########## superset/mcp_service/theme/tool/update_theme.py: ########## @@ -0,0 +1,113 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import logging + +from fastmcp import Context +from marshmallow import ValidationError +from superset_core.mcp.decorators import tool, ToolAnnotations + +from superset.extensions import event_logger +from superset.mcp_service.theme.schemas import ( + UpdateThemeRequest, + UpdateThemeResponse, +) + +logger = logging.getLogger(__name__) + + +@tool( + tags=["mutate"], + class_permission_name="Theme", + method_permission_name="write", + annotations=ToolAnnotations( + title="Update theme", + readOnlyHint=False, + destructiveHint=True, + ), +) +async def update_theme( + request: UpdateThemeRequest, ctx: Context +) -> UpdateThemeResponse: + """Update an existing Superset theme's name or Ant Design token configuration. + + Provide the ``id`` of the theme to update plus any fields to change. + Fields left as ``None`` are preserved from the existing theme. + System themes cannot be modified. + """ + await ctx.info("Updating theme: id=%s" % (request.id,)) + + try: + from superset.commands.theme.exceptions import ( + SystemThemeProtectedError, + ThemeNotFoundError, + ) + from superset.commands.theme.update import UpdateThemeCommand + from superset.daos.theme import ThemeDAO + from superset.themes.schemas import ThemePutSchema + + # Fetch current theme to support partial updates (merge missing fields) + existing = ThemeDAO.find_by_id(request.id) + if existing is None: + await ctx.warning("Theme not found: id=%s" % (request.id,)) + return UpdateThemeResponse(id=None, error="Theme not found.") + + theme_name = ( + request.theme_name + if request.theme_name is not None + else existing.theme_name + ) + json_data = ( + request.json_data if request.json_data is not None else existing.json_data + ) Review Comment: **Suggestion:** This reads the current theme outside the command transaction and then writes both fields back, which creates a lost-update race: if another request changes `json_data` between the `find_by_id` call and `UpdateThemeCommand.run()`, a name-only update here can overwrite that newer `json_data` with stale data. Move the merge/read into the same transactional update path (or update only explicitly provided fields) to avoid clobbering concurrent writes. [race condition] <details> <summary><b>Severity Level:</b> Major ⚠️</summary> ```mdx - ❌ Concurrent theme edits can overwrite newer json_data values. - ⚠️ MCP clients may observe silently reverted theme configuration. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. Start the MCP server as in the PR description (entrypoint `superset/mcp_service/app.py`, which registers the `update_theme` tool used in tests at `tests/unit_tests/mcp_service/theme/tool/test_create_theme.py:245-276`). 2. Ensure there is a theme row with id `10` in the database; this mirrors the test fixture `_make_mock_existing_theme()` in `tests/unit_tests/mcp_service/theme/tool/test_create_theme.py:230-241`, which sets `json_data='{"token": {"colorPrimary": "#aaaaaa"}}'`. 3. From two concurrent MCP clients (mirroring the `fastmcp.Client` usage at `tests/unit_tests/mcp_service/theme/tool/test_create_theme.py:261-272`), fire two overlapping `update_theme` calls against the same theme id: (a) Request A sets only `json_data` (non-None) and leaves `theme_name=None`; (b) Request B sets only `theme_name` (non-None) and leaves `json_data=None`. 4. In the `update_theme()` tool (`superset/mcp_service/theme/tool/update_theme.py:43-99`), each request first reads `existing = ThemeDAO.find_by_id(request.id)` outside any transaction at line 64 and computes `theme_name`/`json_data` defaults at lines 69-76, then later calls `UpdateThemeCommand(request.id, item).run()` inside a transaction (`superset/commands/theme/update.py:39-44`); if Request A commits a new `json_data` first, then Request B's later transaction uses the stale `existing.json_data` it read earlier and overwrites the newer value in `ThemeDAO.update(self._model, self._properties)`, producing a lost-update on the `json_data` field. ``` </details> [Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=4725f6f40b214f1dbb9b07fc4a7ebed5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=4725f6f40b214f1dbb9b07fc4a7ebed5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/mcp_service/theme/tool/update_theme.py **Line:** 64:76 **Comment:** *Race Condition: This reads the current theme outside the command transaction and then writes both fields back, which creates a lost-update race: if another request changes `json_data` between the `find_by_id` call and `UpdateThemeCommand.run()`, a name-only update here can overwrite that newer `json_data` with stale data. Move the merge/read into the same transactional update path (or update only explicitly provided fields) to avoid clobbering concurrent writes. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40355&comment_hash=095e0bbb3ca5294f1ab61dde9330af850ba958481e82ae135bda61efbaa1ed8f&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40355&comment_hash=095e0bbb3ca5294f1ab61dde9330af850ba958481e82ae135bda61efbaa1ed8f&reaction=dislike'>👎</a> ########## tests/unit_tests/mcp_service/theme/tool/test_create_theme.py: ########## @@ -0,0 +1,364 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from unittest.mock import MagicMock, patch + +import pytest +from fastmcp import Client + +from superset.mcp_service.app import mcp +from superset.mcp_service.theme.schemas import CreateThemeRequest, UpdateThemeRequest +from superset.utils import json + + [email protected] +def mcp_server(): + return mcp + + [email protected](autouse=True) +def mock_auth(): + from unittest.mock import Mock, patch as _patch + + with _patch("superset.mcp_service.auth.get_user_from_request") as mock_get_user: + mock_user = Mock() + mock_user.id = 1 + mock_user.username = "admin" + mock_get_user.return_value = mock_user + yield mock_get_user + + +# --------------------------------------------------------------------------- +# Schema tests +# --------------------------------------------------------------------------- + + +def test_create_theme_request_string_json_data() -> None: + req = CreateThemeRequest( + theme_name="Blue Theme", + json_data='{"token": {"colorPrimary": "#1677ff"}}', + ) + assert req.theme_name == "Blue Theme" + assert '"colorPrimary"' in req.json_data + + +def test_create_theme_request_dict_json_data() -> None: + """json_data accepts a native dict and serializes it to a JSON string.""" + req = CreateThemeRequest( + theme_name="Blue Theme", + json_data={"token": {"colorPrimary": "#1677ff"}}, + ) + assert isinstance(req.json_data, str) + parsed = json.loads(req.json_data) + assert parsed["token"]["colorPrimary"] == "#1677ff" + + +def test_create_theme_request_missing_name_fails() -> None: + from pydantic import ValidationError + + with pytest.raises(ValidationError): + CreateThemeRequest(json_data='{"token": {}}') + + +def test_create_theme_request_missing_json_data_fails() -> None: + from pydantic import ValidationError + + with pytest.raises(ValidationError): + CreateThemeRequest(theme_name="My Theme") + + +# --------------------------------------------------------------------------- +# Tool logic tests +# --------------------------------------------------------------------------- + + +def _make_mock_theme(id: int = 42, theme_name: str = "Blue Theme") -> MagicMock: + theme = MagicMock() + theme.id = id + theme.theme_name = theme_name + theme.json_data = '{"token": {"colorPrimary": "#1677ff"}}' + return theme + + [email protected] +async def test_create_theme_success(mcp_server: object) -> None: + """Happy path: theme created and ID returned.""" + mock_theme = _make_mock_theme() + + with ( + patch("superset.mcp_service.theme.tool.create_theme.db") as mock_db, + patch( + "superset.mcp_service.theme.tool.create_theme.Theme", + return_value=mock_theme, + ), + ): Review Comment: **Suggestion:** These patch targets do not exist at module scope because `db` and `Theme` are imported inside the tool function body, so the patch setup raises `AttributeError` before the test runs. Patch the real import locations used by the function (or patch with `create=True` plus correct indirection) so tests execute the intended behavior. [api mismatch] <details> <summary><b>Severity Level:</b> Critical 🚨</summary> ```mdx - ❌ create_theme MCP tool tests error during patch setup. - ⚠️ CI cannot validate create_theme behavior via unit tests. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. Run `pytest tests/unit_tests/mcp_service/theme/tool/test_create_theme.py::test_create_theme_success` to execute the create_theme tool test defined at lines 97-124. 2. Pytest imports the target module `superset.mcp_service.theme.tool.create_theme`, where `db` and `Theme` are imported inside the `create_theme()` function body (`superset/mcp_service/theme/tool/create_theme.py:59-62`) and are therefore not attributes on the module object itself. 3. When the test enters the context manager at `tests/unit_tests/mcp_service/theme/tool/test_create_theme.py:102-108`, `patch("superset.mcp_service.theme.tool.create_theme.db")` attempts to resolve attribute `db` on the `create_theme` module, but no such attribute exists because the imports are local to the function; `unittest.mock.patch` raises `AttributeError` during setup, before any MCP `Client` call is made. 4. Because the patching fails, `test_create_theme_success` (and any similar test using this patch target) will error out instead of exercising and asserting the `create_theme` tool behavior; additionally, even if the attribute existed, the patch would not affect the actual lookup locations (`superset.extensions.db` and `superset.models.core.Theme`), so the current targets are not aligned with where the tool resolves its dependencies. ``` </details> [Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=1855f03fbe764ebe9c166f6fb40a97dc&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=1855f03fbe764ebe9c166f6fb40a97dc&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** tests/unit_tests/mcp_service/theme/tool/test_create_theme.py **Line:** 102:108 **Comment:** *Api Mismatch: These patch targets do not exist at module scope because `db` and `Theme` are imported inside the tool function body, so the patch setup raises `AttributeError` before the test runs. Patch the real import locations used by the function (or patch with `create=True` plus correct indirection) so tests execute the intended behavior. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40355&comment_hash=d72f4a9f088b3e6959bf1dcb850c0fdfb80db13bb0b8c578e8a38cf4edb52c7b&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40355&comment_hash=d72f4a9f088b3e6959bf1dcb850c0fdfb80db13bb0b8c578e8a38cf4edb52c7b&reaction=dislike'>👎</a> ########## tests/unit_tests/mcp_service/theme/tool/test_create_theme.py: ########## @@ -0,0 +1,364 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from unittest.mock import MagicMock, patch + +import pytest +from fastmcp import Client + +from superset.mcp_service.app import mcp +from superset.mcp_service.theme.schemas import CreateThemeRequest, UpdateThemeRequest +from superset.utils import json + + [email protected] +def mcp_server(): + return mcp + + [email protected](autouse=True) +def mock_auth(): + from unittest.mock import Mock, patch as _patch + + with _patch("superset.mcp_service.auth.get_user_from_request") as mock_get_user: + mock_user = Mock() + mock_user.id = 1 + mock_user.username = "admin" + mock_get_user.return_value = mock_user + yield mock_get_user + + +# --------------------------------------------------------------------------- +# Schema tests +# --------------------------------------------------------------------------- + + +def test_create_theme_request_string_json_data() -> None: + req = CreateThemeRequest( + theme_name="Blue Theme", + json_data='{"token": {"colorPrimary": "#1677ff"}}', + ) + assert req.theme_name == "Blue Theme" + assert '"colorPrimary"' in req.json_data + + +def test_create_theme_request_dict_json_data() -> None: + """json_data accepts a native dict and serializes it to a JSON string.""" + req = CreateThemeRequest( + theme_name="Blue Theme", + json_data={"token": {"colorPrimary": "#1677ff"}}, + ) + assert isinstance(req.json_data, str) + parsed = json.loads(req.json_data) + assert parsed["token"]["colorPrimary"] == "#1677ff" + + +def test_create_theme_request_missing_name_fails() -> None: + from pydantic import ValidationError + + with pytest.raises(ValidationError): + CreateThemeRequest(json_data='{"token": {}}') + + +def test_create_theme_request_missing_json_data_fails() -> None: + from pydantic import ValidationError + + with pytest.raises(ValidationError): + CreateThemeRequest(theme_name="My Theme") + + +# --------------------------------------------------------------------------- +# Tool logic tests +# --------------------------------------------------------------------------- + + +def _make_mock_theme(id: int = 42, theme_name: str = "Blue Theme") -> MagicMock: + theme = MagicMock() + theme.id = id + theme.theme_name = theme_name + theme.json_data = '{"token": {"colorPrimary": "#1677ff"}}' + return theme + + [email protected] +async def test_create_theme_success(mcp_server: object) -> None: + """Happy path: theme created and ID returned.""" + mock_theme = _make_mock_theme() + + with ( + patch("superset.mcp_service.theme.tool.create_theme.db") as mock_db, + patch( + "superset.mcp_service.theme.tool.create_theme.Theme", + return_value=mock_theme, + ), + ): + mock_db.session.flush = MagicMock() + + async with Client(mcp_server) as client: + request = CreateThemeRequest( + theme_name="Blue Theme", + json_data='{"token": {"colorPrimary": "#1677ff"}}', + ) + result = await client.call_tool( + "create_theme", {"request": request.model_dump()} + ) + data = json.loads(result.content[0].text) + + assert data["id"] == 42 + assert data["theme_name"] == "Blue Theme" + assert data["error"] is None + + [email protected] +async def test_create_theme_with_dict_json_data(mcp_server: object) -> None: + """Tool accepts json_data as a dict (native object) from LLM clients.""" + mock_theme = _make_mock_theme() + + with ( + patch("superset.mcp_service.theme.tool.create_theme.db") as mock_db, + patch( + "superset.mcp_service.theme.tool.create_theme.Theme", + return_value=mock_theme, + ), + ): + mock_db.session.flush = MagicMock() + + async with Client(mcp_server) as client: + result = await client.call_tool( + "create_theme", + { + "request": { + "theme_name": "Blue Theme", + "json_data": {"token": {"colorPrimary": "#1677ff"}}, + } + }, + ) + data = json.loads(result.content[0].text) + + assert data["id"] == 42 + assert data["error"] is None + + [email protected] +async def test_create_theme_validation_error_empty_name(mcp_server: object) -> None: + """Empty theme name is caught by ThemePostSchema and returned as error.""" + async with Client(mcp_server) as client: + result = await client.call_tool( + "create_theme", + { + "request": { + "theme_name": " ", + "json_data": '{"token": {}}', + } + }, + ) + data = json.loads(result.content[0].text) + + assert data["id"] is None + assert data["error"] is not None + assert "empty" in str(data["error"]).lower() + + [email protected] +async def test_create_theme_validation_error_invalid_json(mcp_server: object) -> None: + """Malformed json_data string is caught by ThemePostSchema.""" + async with Client(mcp_server) as client: + result = await client.call_tool( + "create_theme", + { + "request": { + "theme_name": "Test", + "json_data": "not-valid-json{{{", + } + }, + ) + data = json.loads(result.content[0].text) + + assert data["id"] is None + assert data["error"] is not None + + +# --------------------------------------------------------------------------- +# UpdateThemeRequest schema tests +# --------------------------------------------------------------------------- + + +def test_update_theme_request_dict_json_data() -> None: + """json_data accepts a native dict and serializes it.""" + req = UpdateThemeRequest( + id=1, + json_data={"token": {"colorPrimary": "#ff0000"}}, + ) + assert isinstance(req.json_data, str) + parsed = json.loads(req.json_data) + assert parsed["token"]["colorPrimary"] == "#ff0000" + + +def test_update_theme_request_no_json_data() -> None: + """json_data defaults to None (partial update).""" + req = UpdateThemeRequest(id=1, theme_name="New Name") + assert req.json_data is None + assert req.theme_name == "New Name" + + +def test_update_theme_request_missing_id_fails() -> None: + from pydantic import ValidationError + + with pytest.raises(ValidationError): + UpdateThemeRequest(theme_name="Test") + + +# --------------------------------------------------------------------------- +# update_theme tool tests +# --------------------------------------------------------------------------- + + +def _make_mock_existing_theme( + id: int = 10, + theme_name: str = "Old Theme", + json_data: str = '{"token": {"colorPrimary": "#aaaaaa"}}', + is_system: bool = False, +) -> MagicMock: + theme = MagicMock() + theme.id = id + theme.theme_name = theme_name + theme.json_data = json_data + theme.is_system = is_system + return theme + + [email protected] +async def test_update_theme_success(mcp_server: object) -> None: + """Happy path: theme updated and new values returned.""" + existing = _make_mock_existing_theme() + updated = _make_mock_existing_theme( + theme_name="New Name", json_data='{"token": {"colorPrimary": "#1677ff"}}' + ) + + with ( + patch("superset.mcp_service.theme.tool.update_theme.ThemeDAO") as mock_dao, + patch( + "superset.mcp_service.theme.tool.update_theme.UpdateThemeCommand" + ) as mock_cmd_class, + ): Review Comment: **Suggestion:** `ThemeDAO` and `UpdateThemeCommand` are imported inside `update_theme()` and are not module-level attributes, so this patch target is invalid and will fail test setup with `AttributeError`. Patch the symbols where they are actually resolved during function execution to make the unit tests runnable. [api mismatch] <details> <summary><b>Severity Level:</b> Critical 🚨</summary> ```mdx - ❌ update_theme MCP tool tests crash before executing logic. - ⚠️ MCP update_theme behavior remains unverified in unit tests. ``` </details> <details> <summary><b>Steps of Reproduction ✅ </b></summary> ```mdx 1. Run `pytest tests/unit_tests/mcp_service/theme/tool/test_create_theme.py::test_update_theme_success` (or any of the update tests at lines 245-276, 279-308, 310-331, 334-363) to exercise the `update_theme` MCP tool. 2. Pytest imports the `superset.mcp_service.theme.tool.update_theme` module, where `ThemeDAO` and `UpdateThemeCommand` are imported inside the `update_theme()` function body (`superset/mcp_service/theme/tool/update_theme.py:55-61`) and therefore are not exposed as module-level attributes on `superset.mcp_service.theme.tool.update_theme`. 3. When the test enters the context manager at `tests/unit_tests/mcp_service/theme/tool/test_create_theme.py:252-257`, `patch("superset.mcp_service.theme.tool.update_theme.ThemeDAO")` and `patch("superset.mcp_service.theme.tool.update_theme.UpdateThemeCommand")` both attempt to resolve non-existent module attributes, causing `unittest.mock.patch` to raise `AttributeError` before the test can call `fastmcp.Client(mcp_server).call_tool("update_theme", ...)` at lines 261-271. 4. As a result, all update_theme tests fail during setup instead of asserting the tool logic; moreover, even if these attributes existed, the patch targets would not align with the actual resolution sites (`superset.daos.theme.ThemeDAO` and `superset.commands.theme.update.UpdateThemeCommand` as imported inside the function), so the tests are not correctly isolating the dependencies used by `update_theme()`. ``` </details> [Fix in Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=dea2404ed2724523bb68a458fe21bba5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) | [Fix in VSCode Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=dea2404ed2724523bb68a458fe21bba5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** tests/unit_tests/mcp_service/theme/tool/test_create_theme.py **Line:** 252:257 **Comment:** *Api Mismatch: `ThemeDAO` and `UpdateThemeCommand` are imported inside `update_theme()` and are not module-level attributes, so this patch target is invalid and will fail test setup with `AttributeError`. Patch the symbols where they are actually resolved during function execution to make the unit tests runnable. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40355&comment_hash=52a1dfd08b2aafa111ba270ad8b5e4ba82f4673a8032547435e56253eb9d540b&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40355&comment_hash=52a1dfd08b2aafa111ba270ad8b5e4ba82f4673a8032547435e56253eb9d540b&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
