rusackas commented on PR #38807: URL: https://github.com/apache/superset/pull/38807#issuecomment-4580230213
> Hey @rusackas, thanks for giving it another look. I think I've applied all of the updates you suggested. > > I updated the branch and rebuilt it locally to test and noticed the symbol wasn't showing on the `Datasources` page. So I updated that to include the symbol as well. I assume there is an ongoing process of moving from `Datasets` to `Datasources`. Let me know if I should undo those changes Honestly, I'm not even sure of that nomenclature shift any more, or how urgent it is... if this works, I'm OK with shoving this through, but perhaps @yousoph or @kasiazjc can weigh in here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
