aminghadersohi commented on code in PR #40361: URL: https://github.com/apache/superset/pull/40361#discussion_r3328078786
########## superset/mcp_service/saved_query/tool/create_saved_query.py: ########## @@ -0,0 +1,126 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import logging +from typing import Any + +from fastmcp import Context +from superset_core.mcp.decorators import tool, ToolAnnotations + +from superset.extensions import event_logger +from superset.mcp_service.saved_query.schemas import ( + CreateSavedQueryRequest, + CreateSavedQueryResponse, +) + +logger = logging.getLogger(__name__) + + +@tool( + tags=["mutate"], + class_permission_name="SavedQuery", + method_permission_name="write", + annotations=ToolAnnotations( + title="Create saved query", + readOnlyHint=False, + destructiveHint=False, + ), +) +async def create_saved_query( + request: CreateSavedQueryRequest, ctx: Context +) -> CreateSavedQueryResponse: Review Comment: Added — unit tests for `create_saved_query` now live in `tests/unit_tests/mcp_service/saved_query/tool/test_create_saved_query.py`. Coverage includes: success path, invalid db_id (SavedQueryInvalidError), create failure (SavedQueryCreateFailedError), optional fields (schema, description, template_parameters), and a new catalog-specific test. ########## superset/mcp_service/saved_query/tool/create_saved_query.py: ########## @@ -0,0 +1,126 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import logging +from typing import Any + +from fastmcp import Context +from superset_core.mcp.decorators import tool, ToolAnnotations + +from superset.extensions import event_logger +from superset.mcp_service.saved_query.schemas import ( + CreateSavedQueryRequest, + CreateSavedQueryResponse, +) + +logger = logging.getLogger(__name__) + + +@tool( + tags=["mutate"], + class_permission_name="SavedQuery", + method_permission_name="write", + annotations=ToolAnnotations( + title="Create saved query", + readOnlyHint=False, + destructiveHint=False, + ), +) +async def create_saved_query( + request: CreateSavedQueryRequest, ctx: Context +) -> CreateSavedQueryResponse: Review Comment: Added — unit tests for `create_saved_query` now live in `tests/unit_tests/mcp_service/saved_query/tool/test_create_saved_query.py`. Coverage includes: success path, invalid db_id (SavedQueryInvalidError), create failure (SavedQueryCreateFailedError), optional fields (schema, description, template_parameters), and a new catalog-specific test. ########## superset/mcp_service/saved_query/tool/update_saved_query.py: ########## @@ -0,0 +1,142 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import logging +from typing import Any + +from fastmcp import Context +from superset_core.mcp.decorators import tool, ToolAnnotations + +from superset.extensions import event_logger +from superset.mcp_service.saved_query.schemas import ( + UpdateSavedQueryRequest, + UpdateSavedQueryResponse, +) + +logger = logging.getLogger(__name__) + +_LOGGABLE_FIELDS = ( + "label", + "sql", + "db_id", + "schema", + "description", + "template_parameters", +) + + +def _build_update_properties(request: "UpdateSavedQueryRequest") -> dict[str, Any]: + """Return only the fields the caller explicitly provided.""" + fields = { + "label": request.label, + "sql": request.sql, + "db_id": request.db_id, + "schema": request.schema, + "description": request.description, + "template_parameters": request.template_parameters, + } + return {k: v for k, v in fields.items() if v is not None} + + +@tool( + tags=["mutate"], + class_permission_name="SavedQuery", + method_permission_name="write", + annotations=ToolAnnotations( + title="Update saved query", + readOnlyHint=False, + destructiveHint=True, + ), +) +async def update_saved_query( + request: UpdateSavedQueryRequest, ctx: Context +) -> UpdateSavedQueryResponse: Review Comment: Added — unit tests for `update_saved_query` now live in `tests/unit_tests/mcp_service/saved_query/tool/test_update_saved_query.py`. Coverage includes: success path, no-fields validation error, SavedQueryNotFoundError, invalid db_id (SavedQueryInvalidError), update failure (SavedQueryUpdateFailedError), and a catalog-specific test. ########## superset/mcp_service/saved_query/tool/update_saved_query.py: ########## @@ -0,0 +1,142 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import logging +from typing import Any + +from fastmcp import Context +from superset_core.mcp.decorators import tool, ToolAnnotations + +from superset.extensions import event_logger +from superset.mcp_service.saved_query.schemas import ( + UpdateSavedQueryRequest, + UpdateSavedQueryResponse, +) + +logger = logging.getLogger(__name__) + +_LOGGABLE_FIELDS = ( + "label", + "sql", + "db_id", + "schema", + "description", + "template_parameters", +) + + +def _build_update_properties(request: "UpdateSavedQueryRequest") -> dict[str, Any]: + """Return only the fields the caller explicitly provided.""" + fields = { + "label": request.label, + "sql": request.sql, + "db_id": request.db_id, + "schema": request.schema, + "description": request.description, + "template_parameters": request.template_parameters, + } + return {k: v for k, v in fields.items() if v is not None} + + +@tool( + tags=["mutate"], + class_permission_name="SavedQuery", + method_permission_name="write", + annotations=ToolAnnotations( + title="Update saved query", + readOnlyHint=False, + destructiveHint=True, + ), +) +async def update_saved_query( + request: UpdateSavedQueryRequest, ctx: Context +) -> UpdateSavedQueryResponse: Review Comment: Added — unit tests for `update_saved_query` now live in `tests/unit_tests/mcp_service/saved_query/tool/test_update_saved_query.py`. Coverage includes: success path, no-fields validation error, SavedQueryNotFoundError, invalid db_id (SavedQueryInvalidError), update failure (SavedQueryUpdateFailedError), and a catalog-specific test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
