aminghadersohi commented on code in PR #40350: URL: https://github.com/apache/superset/pull/40350#discussion_r3328087585
########## superset/mcp_service/css_template/tool/create_css_template.py: ########## @@ -0,0 +1,99 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import logging + +from fastmcp import Context +from superset_core.mcp.decorators import tool, ToolAnnotations + +from superset.extensions import event_logger +from superset.mcp_service.css_template.schemas import ( + CreateCssTemplateRequest, + CreateCssTemplateResponse, +) + +logger = logging.getLogger(__name__) + + +@tool( + tags=["mutate"], + class_permission_name="CssTemplate", + method_permission_name="write", + annotations=ToolAnnotations( + title="Create CSS template", + readOnlyHint=False, + destructiveHint=False, + ), +) +async def create_css_template( + request: CreateCssTemplateRequest, ctx: Context +) -> CreateCssTemplateResponse: + """Create a new CSS template that can be applied to dashboards. + + Use this tool when a user wants to save a CSS stylesheet as a named + template for reuse across multiple dashboards. + + The returned ``id`` can be used when configuring dashboard appearance. + """ + await ctx.info("Creating CSS template: template_name=%r" % (request.template_name,)) Review Comment: Verified with `ruff-format`: this line is exactly 88 characters and within the configured limit. The formatter kept it on a single line when run locally, confirming no E501 violation. ########## superset/mcp_service/css_template/tool/create_css_template.py: ########## @@ -0,0 +1,99 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import logging + +from fastmcp import Context +from superset_core.mcp.decorators import tool, ToolAnnotations + +from superset.extensions import event_logger +from superset.mcp_service.css_template.schemas import ( + CreateCssTemplateRequest, + CreateCssTemplateResponse, +) + +logger = logging.getLogger(__name__) + + +@tool( + tags=["mutate"], + class_permission_name="CssTemplate", + method_permission_name="write", + annotations=ToolAnnotations( + title="Create CSS template", + readOnlyHint=False, + destructiveHint=False, + ), +) +async def create_css_template( + request: CreateCssTemplateRequest, ctx: Context +) -> CreateCssTemplateResponse: Review Comment: Unit tests have been added in `tests/unit_tests/mcp_service/css_template/tool/test_create_css_template.py` and `test_update_css_template.py`. Coverage includes: schema validation (valid, whitespace-stripping, empty name, name too long), success path, `CssTemplateInvalidError`, `CssTemplateCreateFailedError`/`CssTemplateUpdateFailedError`, and unexpected exception re-raise. ########## superset/commands/css/create.py: ########## @@ -0,0 +1,46 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +import logging +from functools import partial +from typing import Any + +from superset.commands.base import BaseCommand +from superset.commands.css.exceptions import ( + CssTemplateCreateFailedError, + CssTemplateInvalidError, +) +from superset.daos.css import CssTemplateDAO +from superset.models.core import CssTemplate +from superset.utils.decorators import on_error, transaction + +logger = logging.getLogger(__name__) Review Comment: Fixed — the unused `logging` import and `logger` assignment have been removed from both tool files. ########## superset/commands/css/update.py: ########## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import logging +from functools import partial +from typing import Any + +from superset.commands.base import BaseCommand +from superset.commands.css.exceptions import ( + CssTemplateInvalidError, + CssTemplateNotFoundError, + CssTemplateUpdateFailedError, +) +from superset.daos.css import CssTemplateDAO +from superset.models.core import CssTemplate +from superset.utils.decorators import on_error, transaction + +logger = logging.getLogger(__name__) Review Comment: Fixed — same as above, unused `logging` import and `logger` removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
