bito-code-review[bot] commented on PR #40546:
URL: https://github.com/apache/superset/pull/40546#issuecomment-4581928495
<!-- Bito Reply -->
The PR comment indicates a logic error in the `ListViewCard` component where
the `url` prop is being sanitized unconditionally, causing unintended
navigation behavior in bulk-select mode. To resolve this, the sanitization
should be applied only when `url` is a real URL, and the `href` should remain
unset when no destination is provided. A suggested fix would be to
conditionally apply the sanitization based on the presence of a valid URL.
**superset-frontend/packages/superset-ui-core/src/components/ListViewCard/index.tsx**
```
const sanitizedUrl = url && isValidUrl(url) ? sanitizeUrl(url) : undefined;
<a href={sanitizedUrl}>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
