bito-code-review[bot] commented on code in PR #40551:
URL: https://github.com/apache/superset/pull/40551#discussion_r3328301608
##########
pyproject.toml:
##########
@@ -71,7 +71,7 @@ dependencies = [
"marshmallow>=3.0, <4",
"marshmallow-union>=0.1",
"msgpack>=1.0.0, <1.2",
- "nh3>=0.2.11, <0.4",
+ "nh3>=0.3.5, <0.4",
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Requirements file not regenerated</b></div>
<div id="fix">
The `nh3` version was bumped to `>=0.3.5` in pyproject.toml but
requirements/base.txt (line 244) and requirements/development.txt (line 569)
still pin `nh3==0.2.21`. This inconsistency means CI/build systems relying on
the pinned requirements files will not pick up the newer version. Per BITO.md
rule [10438], dependencies should be updated through package manager commands
which also regenerates the requirements files.
</div>
</div>
<small><i>Code Review Run #4824e2</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
