rusackas commented on PR #40264: URL: https://github.com/apache/superset/pull/40264#issuecomment-4583519890
## ECharts 5 → 6 changelog review CI is fully green on this PR (all checks pass, including Playwright and Cypress E2E). Here's a summary of the breaking changes from the [6.0.0 release](https://github.com/apache/echarts/releases/tag/6.0.0) and what they mean for Superset: ### Breaking changes | Change | Impact on Superset | Migration | |---|---|---| | **New default theme** — visual style overhauled; legend moves to the bottom by default | Charts will look different to existing users (colors, legend position, spacing) | Use `echarts/theme/v5.js` to restore old style, or accept the new defaults | | **Cartesian axis anti-overflow** — axes shift slightly when labels/names overflow the canvas | Minor layout shifts for charts with long axis labels | Set `grid.outerBoundsMode: 'none'` to disable, or accept | | **`center` percent base changed** on `geo`, `series.map`, `series.graph`, `series.tree` | Affects geo-positioned charts | Set `legacyViewCoordSysCenterBase: true` on the option root to restore | | **Label rich styles now inherit plain label styles** (`fontSize`, `fontFamily`, etc.) | Could affect charts with custom rich-text labels | Set `richInheritPlainLabel: false` to restore old behavior | ### What we import Superset's usage is narrow — only `init as echartsInit`, `SeriesOption`, and `util` are imported from the `echarts` package directly. The actual chart rendering happens through the plugin-chart-echarts plugin. ### Recommendation The new theme changes are the most user-visible. Two paths: 1. **Accept new defaults** — charts will look different to existing Superset users (especially the legend position). No code changes needed. Docs update recommended to note the visual change in release notes. 2. **Restore v5 style** — add `import 'echarts/theme/v5.js'` (or equivalent) to the plugin initialization to preserve existing chart appearance for users upgrading. Given that E2E tests pass, the functional behavior is intact. The main question is whether we want to opt users into the new echarts 6 aesthetic or preserve visual continuity with `v5.js`. Flagging for maintainer decision before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
