bito-code-review[bot] commented on code in PR #40473:
URL: https://github.com/apache/superset/pull/40473#discussion_r3329457037
##########
superset/mcp_service/dataset/schemas.py:
##########
@@ -315,13 +334,80 @@ def create(cls, error: str, error_type: str) ->
"DatasetError":
)
+DEFAULT_GET_DATASET_INFO_COLUMNS: List[str] = [
+ "id",
+ "table_name",
+ "schema",
+ "database_name",
+ "database_id",
+ "uuid",
+ "is_virtual",
+ "description",
+ "main_dttm_col",
+ "sql",
+ "url",
+ "columns",
+ "metrics",
+]
+
+DEFAULT_GET_DATASET_INFO_COLUMN_FIELDS: List[str] = [
+ "column_name",
+ "type",
+ "is_dttm",
+]
Review Comment:
<!-- Bito Reply -->
The suggestion in the comment is valid and worth applying. It highlights a
missing test coverage for the new `select_columns` and `column_fields`
parameters, as well as the lack of unit tests for the `model_serializer` and
field validators. Adding these tests will ensure the correctness and robustness
of the new features under various input scenarios. The suggestion aligns with
best practices for testing and should be implemented to improve the code
quality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
