rusackas commented on code in PR #39535:
URL: https://github.com/apache/superset/pull/39535#discussion_r3329564341
##########
superset-frontend/packages/superset-ui-core/src/components/ModalTrigger/index.tsx:
##########
@@ -84,7 +90,7 @@ export const ModalTrigger = forwardRef(
setShowModal(true);
};
- if (ref) {
+ if (ref && typeof ref !== 'function') {
ref.current = { close, open, showModal }; // eslint-disable-line
}
Review Comment:
Fix was applied in commit 49dbed21 — both object refs and callback refs are
now handled correctly via the callback-ref branch. Bito's original suggestion
was valid and has been addressed. This is a loop artifact from `/resolve` not
being supported on inline comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
