RoySerbi opened a new pull request, #40563: URL: https://github.com/apache/superset/pull/40563
## What this does Fixes #40401 Replaces the native browser `prompt()` dialog with a styled Superset Modal for the SQL Lab tab rename feature. **Before:** Native browser `prompt()` dialog (unstyled, blocked in some environments) **After:** Superset-styled Modal with Input field, consistent with the rest of the UI ## Changes - `SqlEditorTabHeader/index.tsx`: Replaced `prompt()` call with a controlled `Modal` component containing an `Input` field - Added `useState` for modal visibility and title state - Modal pre-fills the current tab name - Rename button disabled when input is empty - Supports Enter key to confirm - Follows the same Modal pattern used by `CREATE TABLE/VIEW AS` in `SqlEditor/index.tsx` ## How it works Clicking "Rename tab" in the context menu now opens a styled Modal dialog instead of the browser's native prompt. The modal includes: - A text input pre-filled with the current tab name - Cancel and Rename buttons (Rename is disabled when input is empty) - Enter key support for quick confirmation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
