etr2460 commented on a change in pull request #8224: [sqllab] create query
slightly earlier
URL:
https://github.com/apache/incubator-superset/pull/8224#discussion_r325406007
##########
File path: superset/views/core.py
##########
@@ -2608,11 +2601,21 @@ def sql_json(self):
session.add(query)
session.flush()
query_id = query.id
- session.commit() # shouldn't be necessary
+ session.commit()
Review comment:
why'd we remove the comment here? By flushing, i think the commit should
happen automatically, so it does seem that this still shouldn't be necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
