villebro opened a new pull request, #102:
URL: https://github.com/apache/superset-kubernetes-operator/pull/102
## Summary
Closes two parity gaps documented in the migration guide. First, it adds
`deploymentTemplate.labels` and `deploymentTemplate.annotations` so users can
attach metadata to the Deployment object itself (e.g. to drive third-party
controllers) — previously only pod-, service-, and route-level metadata was
exposed. Second, it corrects the migration guide, which incorrectly claimed the
built-in Ingress reconciler "targets the web server service only": the Ingress
reconciler has long done the same per-component fan-out as Gateway API (`/` web
server, plus `/ws`, `/flower`, `/mcp` for present components). That stale claim
appeared in five places and contradicted our own `networking-and-monitoring.md`.
## Details
**New fields**
- `DeploymentTemplate` gains `Labels`/`Annotations` maps
(`api/v1alpha1/shared_types.go`), resolved top-level + per-component via the
existing `MergeMaps` helper (component wins on key conflict).
- Applied to the Deployment `ObjectMeta` in `reconcileComponentDeployment`,
with operator-managed labels merged **last** so they stay protected and cannot
be overridden. These land on Deployment metadata only, so changes do not
trigger a pod rollout.
- Reworked the `MergeDeploymentTemplate` emptiness guard from `*result ==
DeploymentTemplate{}` to a field-wise nil check, since a struct containing maps
is no longer comparable with `==`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
