betodealmeida commented on code in PR #40466:
URL: https://github.com/apache/superset/pull/40466#discussion_r3334656784
##########
superset-frontend/src/features/databases/DatabaseModal/DatabaseConnectionForm/EncryptedField.tsx:
##########
@@ -51,13 +51,17 @@ export const EncryptedField = ({
isEditMode,
db,
editNewDb,
+ isPublic = true,
+ setIsPublic,
}: FieldPropTypes) => {
const [fileList, setFileList] = useState<UploadFile[]>([]);
const [uploadOption, setUploadOption] = useState<number>(
CredentialInfoOptions.JsonUpload.valueOf(),
);
const { addDangerToast } = useToasts();
- const showCredentialsInfo = !isEditMode;
+ const isGSheets = db?.engine === Engines.GSheet;
Review Comment:
One of the design principles of the "dynamic" database forms was that we
wouldn't need custom logic for specific DBs — the idea was that each DB defines
the JSON schema of what it needs, and the UI builds it. Unfortunately we never
got that right, and we ended up with a lot of DB-specific logic.
In the near-ish future we should refactor this. I started a PR last year,
I'll revisit once I'm done with semantic layers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
