Copilot commented on code in PR #40393: URL: https://github.com/apache/superset/pull/40393#discussion_r3335995731
########## superset-frontend/plugins/plugin-chart-point-cluster-map/src/components/ScatterPlotOverlay.tsx: ########## @@ -26,6 +26,9 @@ import luminanceFromRGB from '../utils/luminanceFromRGB'; export const MIN_CLUSTER_RADIUS_RATIO = 1 / 6; export const MAX_POINT_RADIUS_RATIO = 1 / 3; +export const isValidCanvasRadius = (value: number) => + Number.isFinite(value) && value > 0; Review Comment: `isValidCanvasRadius` reads like it matches the CanvasRenderingContext2D `arc()` contract, but this implementation intentionally rejects `0` (which is non-negative and acceptable for `arc()`), effectively meaning “finite and strictly positive”. Consider renaming to reflect the predicate (e.g. `isPositiveFiniteRadius`) to avoid confusion for future reuse. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
