aminghadersohi commented on code in PR #40351: URL: https://github.com/apache/superset/pull/40351#discussion_r3336210040
########## superset/mcp_service/annotation_layer/tool/update_layer_annotation.py: ########## @@ -0,0 +1,153 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import logging +from typing import Any + +from fastmcp import Context +from superset_core.mcp.decorators import tool, ToolAnnotations + +from superset.extensions import event_logger +from superset.mcp_service.annotation_layer.schemas import ( + UpdateLayerAnnotationRequest, + UpdateLayerAnnotationResponse, +) + +logger = logging.getLogger(__name__) + + +def _build_update_properties(request: UpdateLayerAnnotationRequest) -> dict[str, Any]: + """Build the properties dict for UpdateAnnotationCommand from the request.""" + properties: dict[str, Any] = {"layer": request.layer_id} + if request.short_descr is not None: + properties["short_descr"] = request.short_descr + if request.start_dttm is not None: + properties["start_dttm"] = request.start_dttm + if request.end_dttm is not None: + properties["end_dttm"] = request.end_dttm + if request.long_descr is not None: + properties["long_descr"] = request.long_descr + if request.json_metadata is not None: + properties["json_metadata"] = request.json_metadata Review Comment: Fixed. now uses to distinguish between 'field not provided' and 'explicitly set to null'. Fields like and are only included in the update payload when they were explicitly present in the request — this allows clearing them by passing . A new test `test_update_layer_annotation_clear_nullable_fields` verifies this end-to-end (commit e5e4a8bc). ########## superset/mcp_service/annotation_layer/tool/update_layer_annotation.py: ########## @@ -0,0 +1,153 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import logging +from typing import Any + +from fastmcp import Context +from superset_core.mcp.decorators import tool, ToolAnnotations + +from superset.extensions import event_logger +from superset.mcp_service.annotation_layer.schemas import ( + UpdateLayerAnnotationRequest, + UpdateLayerAnnotationResponse, +) + +logger = logging.getLogger(__name__) + + +def _build_update_properties(request: UpdateLayerAnnotationRequest) -> dict[str, Any]: + """Build the properties dict for UpdateAnnotationCommand from the request.""" + properties: dict[str, Any] = {"layer": request.layer_id} + if request.short_descr is not None: + properties["short_descr"] = request.short_descr + if request.start_dttm is not None: + properties["start_dttm"] = request.start_dttm + if request.end_dttm is not None: + properties["end_dttm"] = request.end_dttm + if request.long_descr is not None: + properties["long_descr"] = request.long_descr Review Comment: Fixed. `_build_update_properties` now uses `model_fields_set` for `long_descr`: it is included in the update payload only when the field was explicitly present in the request (distinguishes 'omitted' from 'explicitly null'). Verified by `test_update_layer_annotation_clear_nullable_fields` (commit e5e4a8bc). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
