rusackas commented on PR #40377: URL: https://github.com/apache/superset/pull/40377#issuecomment-4595646617
Added a regression test for `SupersetProfiler` (`tests/unit_tests/utils/profiler_test.py`), which was the only code that integrates with pyinstrument and previously had **zero** coverage. It exercises the three API surfaces the middleware depends on — `Profiler(interval=...)`, the context-manager protocol, and `output_html()` — plus the pass-through and "not installed" paths. I verified it passes against **both** pyinstrument 4.4.0 and 5.1.2, so the 5.x API is compatible with our usage. ⚠️ Heads-up: this PR only raises the `pyproject.toml` floor; `requirements/development.txt` still pins `pyinstrument==4.4.0`, which is what CI installs. So CI here is actually testing 4.4.0, not 5.1.2. The integration is now guarded by the test regardless, but to genuinely apply (and CI-test) the bump, the lockfile should be regenerated to 5.1.2 in a follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
