rusackas commented on PR #34111: URL: https://github.com/apache/superset/pull/34111#issuecomment-4596882843
Trying to figure out what to do with this one. My robots basically say: The fix works operationally (mutator now fires) but is semantically wrong, passing `is_split=config["MUTATE_AFTER_SPLIT"]` making the guard always True. @mistercrunch identified the deeper design: `is_split` was meant to convey whether SQL is already-split, so the correct fix is to bypass `mutate_sql_based_on_config` entirely in SQLLab and call `SQL_QUERY_MUTATOR` directly. Behavioral risk: `MUTATE_AFTER_SPLIT=False` users may expect one pre-split mutation but now get per-block calls, an observable difference for multi-statement queries. Zero new tests. Both MUTATE_AFTER_SPLIT=True and False paths should be covered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
