rusackas opened a new pull request, #40607: URL: https://github.com/apache/superset/pull/40607
### SUMMARY In the AG Grid table plugin's filter converter, range (`IN_RANGE` → `BETWEEN`) filter operands are interpolated into the generated clause **without quoting**, so they need to be finite numbers. Previously the raw `filter`/`filterTo` values were passed straight through, even though the filter value path accepts strings — which could produce a malformed clause if the operands weren't numeric. This coerces both bounds with `Number()` and **skips the clause entirely when either is not a finite number**, so only well-formed numeric ranges are emitted. Valid numeric ranges are unchanged. ### BEFORE / AFTER For a metric range filter, the generated `HAVING`: - **Before:** `revenue BETWEEN <raw> AND <raw>` (operands passed through as-is) - **After:** emitted only when both bounds coerce to finite numbers (`revenue BETWEEN 10 AND 20`); otherwise no clause is generated. ### TESTING INSTRUCTIONS ```bash cd superset-frontend && npx jest plugins/plugin-chart-ag-grid-table/test/utils/agGridFilterConverter.test.ts ``` Adds two regression tests (numeric bounds → BETWEEN clause; non-numeric bound → no clause). Full file: 47/47 pass. ### ADDITIONAL INFORMATION - [ ] Has associated issue: n/a - [ ] Changes UI: No - [ ] Includes DB Migration: No - [ ] Introduces new feature or API: No - [ ] Removes existing feature or API: No 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
