bito-code-review[bot] commented on PR #40634:
URL: https://github.com/apache/superset/pull/40634#issuecomment-4597456143
<!-- Bito Reply -->
The PR introduces a `Range(max=10000)` validation for the `periods` field in
`ChartDataProphetOptionsSchema`, but the field metadata only documents a
minimum (`"min": 0`). To ensure consistency between the schema and validation
logic, you should update the metadata to include the maximum value (`"max":
10000`) as well. This will keep the generated documentation and schema in sync
with the actual validation behavior.
**superset/charts/schemas.py**
```
periods = fields.Integer(
metadata={
"min": 0,
},
validate=[
Range(
min=0,
max=10000,
error=_("`periods` must be between 0 and 10000"),
)
],
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
