betodealmeida opened a new pull request #8251: Small fix for Presto dtype map URL: https://github.com/apache/incubator-superset/pull/8251 ### CATEGORY Choose one - [X] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Pandas doesn't recognize the `timedelta64` dtype, instead we need to use `timedelta64[ns]`. When querying a Presto table I'm getting the error: > The 'datetime64' dtype has no unit. Please pass in 'datetime64[ns]' instead. This PR fixes it. <!--### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF--> <!--- Skip this if not applicable --> ### TEST PLAN <!--- What steps should be taken to verify the changes --> Added unit test. Tested with real data, now it works. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @khtruong
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
