bito-code-review[bot] commented on PR #40653: URL: https://github.com/apache/superset/pull/40653#issuecomment-4597687518
<!-- Bito Reply --> The warning about 'algorithm not pinned' not triggering in normal configuration appears to be a design choice in the implementation. Since `create_default_mcp_auth_factory()` ensures a non-falsy `algorithm` is always provided (defaulting to 'RS256'), the `_warn_on_weak_jwt_config()` function does not raise a warning in cases where the algorithm is not explicitly set. This behavior may contradict the PR's intent if the goal was to enforce explicit algorithm pinning, but it aligns with the current logic of the codebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
