bito-code-review[bot] commented on code in PR #40643: URL: https://github.com/apache/superset/pull/40643#discussion_r3339030275
########## superset/translations/pt/LC_MESSAGES/messages.po: ########## @@ -10854,8 +10854,6 @@ msgstr "Filtro de data" msgid "Registration date" msgstr "Início" -msgid "Registration hash" -msgstr "" msgid "Registration successful" msgstr "" Review Comment: <div> <div id="suggestion"> <div id="issue"><b>CWE-532: Incomplete Translation Cleanup</b></div> <div id="fix"> The diff correctly removes the `Registration hash` entry from Portuguese as part of the security fix ([CWE-532](https://cwe.mitre.org/data/definitions/532.html): bearer token exposure). However, the same commit missed removing this msgid from two other locale files — `fi` (Finnish) and `th` (Thai) — leaving orphaned entries at fi:19135 and th:18917 respectively. These will cause babel-extract regression check failures since the msgid no longer exists in source code. </div> </div> <details> <summary><b>Citations</b></summary> <ul> <li> Rule Violated: <a href="https://github.com/apache/superset/blob/cbf86ca/AGENTS.md#L69";>AGENTS.md:69</a> </li> </ul> </details> <small><i>Code Review Run #f5996e</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
