rebenitez1802 commented on PR #40622: URL: https://github.com/apache/superset/pull/40622#issuecomment-4602307771
One substantive thing before merge: the transformer can be bypassed with a leading control character. .trim() only strips whitespace, and the scheme comparison uses replace(/\s/g, '') — neither covers the non-whitespace C0 controls (\x00–\x08, \x0e–\x1f). Browsers (per the WHATWG URL parser) strip all leading C0 controls + space before resolving the scheme, so \x01javascript:alert(1) executes on click but passes through this transformer untouched. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
