gkneighb commented on PR #40398: URL: https://github.com/apache/superset/pull/40398#issuecomment-4603168922
Closing as superseded by #40448 (merged 2026-05-28), which independently added the same `sql_expression` field on `ColumnRef` with broader chart-type coverage and per-chart-config Pydantic-level position scoping. Specifically, #40448 covers: - The same field shape (`sql_expression: str | None` on `ColumnRef`, emits an `expressionType: "SQL"` adhoc dict in form_data) - The same mutual-exclusion guards (`sql_expression` with `name` / `aggregate` / `saved_metric`) - Broader position scoping via per-config `reject_sql_expression_on_dimensions` model validators on `XYChartConfig`, `MixedTimeseriesChartConfig`, `PieChartConfig`, `PivotTableChartConfig`, `HandlebarsChartConfig`, and `TableChartConfig` (raw mode) — catches the error at Pydantic schema layer rather than at Tier-1 dataset validation - Integration with `chart_type_suggester` and runtime validator hooks that this PR didn't reach Thanks @aminghadersohi for the review here — apologies for the duplicated effort; #40448 wasn't on my radar when I opened this. Closing without merge to avoid double-work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
