rusackas commented on code in PR #40625:
URL: https://github.com/apache/superset/pull/40625#discussion_r3342405034
##########
superset-websocket/src/config.ts:
##########
@@ -114,6 +116,7 @@ function applyEnvOverrides(config: ConfigType): ConfigType {
(config.redisStreamReadBlockMs = toNumber(val)),
JWT_SECRET: val => (config.jwtSecret = val),
JWT_COOKIE_NAME: val => (config.jwtCookieName = val),
+ ALLOWED_ORIGINS: val => (config.allowedOrigins = toStringArray(val)),
SOCKET_RESPONSE_TIMEOUT_MS: val =>
Review Comment:
Agreed — `toStringArray()` now trims each entry and drops empties, so
`"https://a.example, https://b.example"` parses to clean origins without the
leading space. This also benefits the other consumers (e.g.
`STATSD_GLOBAL_TAGS`). Fixed in 571f4279b3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
