bito-code-review[bot] commented on code in PR #40628:
URL: https://github.com/apache/superset/pull/40628#discussion_r3342418885
##########
superset-frontend/src/features/databases/DatabaseModal/DatabaseConnectionForm/EncryptedField.test.tsx:
##########
@@ -173,13 +194,18 @@ describe('EncryptedField', () => {
},
];
Review Comment:
<!-- Bito Reply -->
The suggestion provided by the reviewer is appropriate and improves the test
coverage by ensuring that boolean values are correctly serialized in create
mode. Applying this change is recommended as it addresses the missing test
cases identified in the review.
**superset-frontend/src/features/databases/DatabaseModal/DatabaseConnectionForm/EncryptedField.test.tsx**
```
+ { input: true, expected: 'true', description: 'booleans to strings' },
+ { input: false, expected: 'false', description: 'false booleans to
strings' },
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
