rusackas opened a new pull request, #40684:
URL: https://github.com/apache/superset/pull/40684
### SUMMARY
Follow-up to #40646. That PR was squash-merged before @aminghadersohi's
re-review (posted after the `merge-if-green` label) was addressed, so this PR
resolves those points:
- **MEDIUM — double-log in the chart validation pipeline.**
`chart/validation/pipeline.py` already `logger.exception("Validation pipeline
error")`s the original error, then called `_sanitize_validation_error(e)` which
(with the new `log_original=True` default added in #40646) logged the same
error again at INFO. Pass `log_original=False` at that call site.
- **NIT — sanitize `exc` in `_auth_error_handler`.** Wrap it with
`_sanitize_for_log` for consistency with the defense-in-depth applied to every
other auth log site.
- **NIT — readable scopes in the success log.** `" ".join(sorted(scopes))`
so the line reads `scopes=read write` instead of `['read', 'write']`.
### TESTING INSTRUCTIONS
`pytest tests/unit_tests/mcp_service/test_jwt_verifier.py` (28 passed).
pre-commit clean (mypy/ruff/pylint).
### ADDITIONAL INFORMATION
- [ ] Has associated issue
- [x] Required feature flags: n/a
- [x] Changes UI: no
- [x] Includes DB Migration: no
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
