rusackas opened a new pull request, #40685: URL: https://github.com/apache/superset/pull/40685
### SUMMARY Follow-up to #40528. That PR was squash-merged before @aminghadersohi's re-review (posted after the `merge-if-green` label) was addressed, so this PR resolves those points: - **MEDIUM — stale `owners` closure in `handleOnChangeOwners`.** Switched to the functional updater `setOwners(prev => parseSelectedOwners(selectedOwners, options, prev))` so the parse always reads the latest `owners` state rather than the value captured at render time. `selectedOwners`/`options` come from the `onChange` call and are closed over correctly; only the prior-state read needed the functional form. - **NIT — `email` empty-string vs undefined.** `parseSelectedOwners` now leaves `email` undefined when the option carries no email (instead of `|| ''`), keeping the optional `email?` type honest. Unit tests updated. ### TESTING INSTRUCTIONS `npm run test -- src/dashboard/components/PropertiesModal/utils.test.ts` (4 passed). prettier / oxlint / frontend type-check clean. ### ADDITIONAL INFORMATION - [ ] Has associated issue - [x] Required feature flags: n/a - [x] Changes UI: no (behavior-preserving hardening) - [x] Includes DB Migration: no 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
