villebro commented on PR #40663: URL: https://github.com/apache/superset/pull/40663#issuecomment-4604433074
@rusackas I think adding a purge job is fine, but the `KeyValueDAO` already excludes expired entries on `get`, and exposes `delete_expired_entries` which are used wherever a `create` is called (the commands are supposed to handle this). So this is a known design decision. If that design decision needs to be revisited I'm all for reviewing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
