rusackas commented on code in PR #40546:
URL: https://github.com/apache/superset/pull/40546#discussion_r3342881279
##########
superset-frontend/package-lock.json:
##########
@@ -49373,7 +49380,7 @@
"react-js-cron": "^5.2.0",
"react-markdown": "^8.0.7",
"react-resize-detector": "^7.1.2",
- "react-syntax-highlighter": "^16.1.0",
+ "react-syntax-highlighter": "^16.1.1",
"react-ultimate-pagination": "^1.3.2",
Review Comment:
I checked the lockfile diff and it is minimal: `git diff origin/master..HEAD
-- superset-frontend/package-lock.json` is only 7 added lines, all for
`@braintree/[email protected]`. There are no `react-syntax-highlighter` (or
other) version bumps in the diff, and the
`packages/superset-ui-core/package.json` workspace entry does list
`@braintree/sanitize-url`. The line numbers cited are just the alphabetical
insertion point, not unrelated changes.
##########
superset-frontend/package-lock.json:
##########
@@ -48900,7 +48907,7 @@
"dependencies": {
"chalk": "^5.6.2",
"lodash-es": "^4.18.1",
- "yeoman-generator": "^8.1.2",
+ "yeoman-generator": "^8.2.2",
"yosay": "^3.0.0"
},
Review Comment:
No `yeoman-generator` bump is present in this PR — the full lockfile diff is
7 added lines, all for `@braintree/sanitize-url`. The line number here (48858)
is just the insertion offset in a large file, not an unrelated dependency
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
