vgvoleg commented on PR #40170: URL: https://github.com/apache/superset/pull/40170#issuecomment-4605343382
> Hi @vgvoleg thank you for this! The one thing my code review tool suggested was: > > > The one thing worth requesting before merge: a one-liner in UPDATING.md noting that YDB users must now install ydb-sqlglot-plugin (e.g., via pip install "apache-superset[ydb]") to avoid a ValueError on query parsing > > I think it's a good idea to add something to UPDATING.md. Can you please add a note there? Then I'm fine with merging this. thanks a lot for review! done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
