graceguo-supercat commented on a change in pull request #8256: [sql_json]
Ensuring the request body is JSON encoded
URL:
https://github.com/apache/incubator-superset/pull/8256#discussion_r325979526
##########
File path: superset/assets/src/SqlLab/actions/sqlLab.js
##########
@@ -220,9 +220,9 @@ export function runQuery(query) {
};
return SupersetClient.post({
- endpoint: `/superset/sql_json/${window.location.search}`,
- postPayload,
- stringify: false,
+ endpoint: '/superset/sql_json/',
Review comment:
I saw this `stringify: false` setting is from PR #5896. @williaster is there
a special reason to turn off stringify?
if use stringify, do we still need `parseMethod: 'text'`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
